Completely cache the Debian PostgreSQL versions

This uses a block that won't run if @deb_postgresql_versions is already set.
theforeman · Oct 17, 2024 · c709f56 · c709f56
1 parent 568845e
commit c709f56
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/lib/foreman_maintain/concerns/base_database.rb b/lib/foreman_maintain/concerns/base_database.rb
@@ -16,11 +16,12 @@ def deb_postgresql_data_dir
       end
 
       def deb_postgresql_versions
-        installed_pkgs = package_manager.list_installed_packages('${binary:Package}\n')
-        @deb_postgresql_versions ||= installed_pkgs.grep(/^postgresql-\d+$/).map do |name|
-          name.split('-').last
-        end
-        @deb_postgresql_versions
+        @deb_postgresql_versions ||= begin
+                                       installed_pkgs = package_manager.list_installed_packages('${binary:Package}\n')
+                                       installed_pkgs.grep(/^postgresql-\d+$/).map do |name|
+                                         name.split('-').last
+                                       end
+                                     end
       end
 
       def postgresql_conf