23.0.2 - Cherry-picks for content-mismatch with 23.0.1 #631
+15
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 735b40161176be270934998a126b42e90c0e9724[1] the host's facts are cached, which is great at runtime but it breaks the tests. The cache can be bypassed by calling it with a list of explicit fact names. [1]: theforeman/foreman@735b401 (cherry picked from commit 1bb3b25)
Since Foreman 2.0 there has been a UserMenu service that provides the entire user menu. At some point the UI also changed to retrieve this dynamically rather than include it in the actual HTML. This rewrites the test to use the service, rather than testing the base template indirectly. (cherry picked from commit 13fa3e7)
Redirect to the correct page after provisioning discovered hosts, based on user settings. (cherry picked from commit 1a11647)
The "unit" tests also include system tests. (cherry picked from commit 248085b)
nofaralfasi
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally pushed version
23.0.1from my repository [0] , making it unavailable in theupstream.This PR will match the changes with my fork [1] and create a new 23.0.2 version with one additional fix [2]
[0] https://github.com/stejskalleos/foreman_discovery/commits/develop/
[1] https://my.diffend.io/gems/foreman_discovery/23.0.0/23.0.1
[2] 98aee2c