-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manage Copr projects #9290
Manage Copr projects #9290
Conversation
b57b53c
to
b6baadc
Compare
2ce9cb6
to
e831f7c
Compare
package_manifest.yaml
Outdated
@@ -29,9 +29,31 @@ all: | |||
dist: '.el8' | |||
macros: | |||
foremandist: "{{ foremandist }}" | |||
copr_project_user: "theforeman" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no such user (but there is a @theforeman
group), which makes me wonder if this variable is really more a copr_project_namespace
?
Conceptual question: the foreman, plugins and katello settings for external repos and modules are rather identical (foreman has puppet, but that also doesn't hurt the others), should we try to unify those? Either via a variable or an yaml anchor? Both would allow override if need be, but prevent unsynchronized changes by default |
This can be reviewed now in context with theforeman/obal#344. I am additionally looking into spinning up a secondary Jenkins job that will run Copr builds in parallel to our Koji builds to allow us some period of testing and building parity. |
[test rpm-copr] |
2 similar comments
[test rpm-copr] |
[test rpm-copr] |
[test rpm-copr] |
9 similar comments
[test rpm-copr] |
[test rpm-copr] |
[test rpm-copr] |
[test rpm-copr] |
[test rpm-copr] |
[test rpm-copr] |
[test rpm-copr] |
[test rpm-copr] |
[test rpm-copr] |
1aff41b
to
622d33d
Compare
[test rpm-copr] |
3 similar comments
[test rpm-copr] |
[test rpm-copr] |
[test rpm-copr] |
e257e59
to
8aad743
Compare
[test rpm-copr] |
The Obal code that supports this work has been merged. This change does not shift us over to Copr directly. This change provides the needed structure to allow us to begin doing Copr scratch builds on every PR and will be conditionally handled by the new rpm-copr job (theforeman/jenkins-jobs#343). My plan is:
|
I have added comps file support here which requires theforeman/obal#358 |
- 'python39:3.9' | ||
- 'nodejs:12' | ||
external_repos: | ||
- https://download.copr.fedorainfracloud.org/results/@theforeman/foreman-nightly-staging/rhel-8-x86_64/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copr can refer to other coprs using copr://user/project
syntax -- no idea if that's better or worse, but wanted to point it out :)
this comment is still open ;-) |
6ecfae8
to
91658e9
Compare
Check it now, I added some variables. |
heh, doing things behind my back while I review… LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
formal ack, yada yada ;)
Hooray -- I have jobs created for this theforeman/jenkins-jobs#343 |
As we consider a move towards Copr, this aims to manage the projects and configuration directly alongside our packages rather than in tool_belt as we did with Koji. This should allow better cohesion when branching between packages and where they are built.
This will require -- theforeman/obal#345