-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Global Registration instead of katello_ca_consumer rpm #745
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than that, no comments. @ares can you double check?
guides/common/modules/proc_registering-capsule-to-satellite-server.adoc
Outdated
Show resolved
Hide resolved
There are conflicts, please rebase. @ares do you have some time to review this? LGTM |
guides/common/modules/proc_using-activation-keys-for-host-registration.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few suggestions, let me know your thouhts (and please ping me directly on irc when ready)
guides/common/modules/proc_using-activation-keys-for-host-registration.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_registering-to-satellite-server.adoc
Outdated
Show resolved
Hide resolved
guides/common/modules/proc_registering-capsule-to-satellite-server.adoc
Outdated
Show resolved
Hide resolved
guides/doc-Configuring_Load_Balancer/topics/Registering_Clients.adoc
Outdated
Show resolved
Hide resolved
guides/doc-Managing_Hosts/topics/proc_registering-a-host-to-satellite-manually.adoc
Outdated
Show resolved
Hide resolved
guides/doc-Managing_Hosts/topics/proc_registering-a-host-to-satellite-manually.adoc
Show resolved
Hide resolved
Rebased & updated with some tweaks:
Affected guides:
|
@ares can you re-review please? please rebase too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All my comments were addressed. It needs rebase now and a response to @lzap's comments.
4a5b9c1
to
3169ed4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Damn sorry my review was in pending state. Sure, let's go. We can optionally tune the security concern.
3169ed4
to
71717ca
Compare
71717ca
to
f39e6cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
#642 is merged & we should propagate global registration as default method