Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Global Registration instead of katello_ca_consumer rpm #745

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

stejskalleos
Copy link
Contributor

#642 is merged & we should propagate global registration as default method

Copy link
Member

@lzap lzap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, no comments. @ares can you double check?

@lzap
Copy link
Member

lzap commented Oct 18, 2021

There are conflicts, please rebase.

@ares do you have some time to review this? LGTM

Copy link
Member

@ares ares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions, let me know your thouhts (and please ping me directly on irc when ready)

@stejskalleos
Copy link
Contributor Author

Rebased & updated with some tweaks:

  • Created common/modules/proc_host_registration_steps.adoc with registration steps that are same for other guides
  • proc_registering-a-host-to-satellite-manually.adoc merged to guides/doc-Managing_Hosts/topics/Registering_Hosts.adoc as it had almost same steps

Affected guides:

  • doc-Configuring_Load_Balancer
  • doc-Content_Management_Guide
  • doc-Managing_Hosts

@lzap
Copy link
Member

lzap commented Oct 22, 2021

@ares can you re-review please? please rebase too.

Copy link
Member

@ares ares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All my comments were addressed. It needs rebase now and a response to @lzap's comments.

Copy link
Member

@lzap lzap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn sorry my review was in pending state. Sure, let's go. We can optionally tune the security concern.

Copy link
Member

@lzap lzap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lzap lzap merged commit b88b60b into theforeman:master Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants