Fix hidden headings behind navigation bar [upstream only] #3454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lennonka
force-pushed
the
fix-navbar-hidden-heading
branch
6 times, most recently
from
44ce329
to
065762b
Compare
Lennonka
force-pushed
the
fix-navbar-hidden-heading
branch
from
065762b
to
3a6b064
Compare
|
I did it!!! 🎉 |
Lennonka
changed the title
maximiliankolb
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
That's awesome, thank you Lena! Tested on https://theforeman-foreman-documentation-preview-pr-3454.surge.sh/nightly/Administering_Project/index-katello.html#Viewing_the_Ansible_Modules_admin ✔️
This was feedback by @lumarel at Foreman Birthday Party and I assume that a lot of people will be very happy with that change!
|
Aren't we going to cherry pick it to stable branches? |
|
We probably should, but on my phone now. Anyone who can do it before I get to it should feel free to do so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Fixing problem with misplaced headings when clicking an item in the TOC
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
UX improvement for Foreman Docs.
Previously, when you clicked an item in the table of contents, the browser scrolled to the top of the page and the actual heading was hidden behind the navigation bar.
With this fix, the heading is visible.
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Checklists
Please cherry-pick my commits into: