Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to Provisioning guide in the "Creating a host" procedure #3443

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rh-max
Copy link
Contributor

@rh-max rh-max commented Nov 8, 2024

What changes are you introducing?

Adding a link to Provisioning guide in the "Creating a host" procedure -- the general procedure is helpful but insufficient.

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

https://issues.redhat.com/browse/SAT-28626

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.13/Katello 4.15 (Satellite 6.17)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16)
  • Foreman 3.11/Katello 4.13 (orcharhino 6.11 on EL8 only)
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • Foreman 3.6/Katello 4.8
  • Foreman 3.5/Katello 4.7 (Satellite 6.13; orcharhino 6.6/6.7)
  • We do not accept PRs for Foreman older than 3.5.

@rh-max rh-max added the Needs style review Requires a review from docs style/grammar perspective label Nov 8, 2024
@@ -4,6 +4,9 @@
Use this procedure to create a host in {ProjectName}.
To use the CLI instead of the {ProjectWebUI}, see the xref:cli-creating-a-host_{context}[].

.Prerequisites
* Review the provider-specific procedures for creating a host in the {ProvisioningDocURL}[Provisioning guide].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have attributes for titles: You can always substitute "URL" for "Title": https://github.com/theforeman/foreman-documentation/blob/master/guides/common/attributes-titles.adoc#L26

@@ -4,6 +4,9 @@
Use this procedure to create a host in {ProjectName}.
To use the CLI instead of the {ProjectWebUI}, see the xref:cli-creating-a-host_{context}[].

.Prerequisites
* Review the provider-specific procedures for creating a host in the {ProvisioningDocURL}[Provisioning guide].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a prerequisite. If the provider-specific procedure exists in the Provisioning guide, the user does not need to follow this generic procedure.

Copy link
Contributor

@Lennonka Lennonka Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Avital. I'd suggest removing most of this procedure anyway because there are many requirements to be met before user can start creating hosts in order to provision them. Therefore, a generic procedure is not helpful. I would only keep the link and delete the procedure steps personally.

@Lennonka Lennonka added the Waiting on contributor Requires an action from the author label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs style review Requires a review from docs style/grammar perspective Waiting on contributor Requires an action from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants