Add diagram of installer-based provisioning with subnet bootdisk #3309
Conversation
Lennonka
added
Needs tech review
| !if ($puppet) | ||
| opt when Puppet enabled | ||
| Host -> Puppet : sends CSR | ||
| Puppet -> Host : sends certificate (if allowed to) |
There was a problem hiding this comment.
I think this would require an additional step -- a loop to check whether Puppet is allowed to send a certificate.
| loop | ||
| Host -> Foreman : requests installation media | ||
| Foreman -> Proxy : requests installation media | ||
| Proxy -> Foreman : provides installation media |
There was a problem hiding this comment.
I think the call would be "Installation media" because it is in response to a request. Same comment for next line.
|
Could you please embed the diagram in an adoc file so that we can see how the diagram renders? |
guides/image-sources/provisioning-installer-bootdisk-subnet.plantuml
Outdated
Show resolved
Hide resolved
guides/image-sources/provisioning-installer-bootdisk-subnet.plantuml
Outdated
Show resolved
Hide resolved
guides/image-sources/provisioning-installer-bootdisk-subnet.plantuml
Outdated
Show resolved
Hide resolved
| !include prov-installation-media.iuml | ||
| note over Host : OS is installed | ||
| !include prov-initial-configuration.iuml | ||
| Host -> Foreman : calls home\n(disables build mode) |
There was a problem hiding this comment.
I'm not entirely sure.
@stejskalleos Can you please explain what "call home" means? Could we use a different wording?
guides/image-sources/provisioning-installer-bootdisk-subnet.plantuml
Outdated
Show resolved
Hide resolved
|
@apinnick There's a rendered PNG file of the diagram included with the PR for a preview. Currently, there's no good place to include them. |
|
@apinnick FYI, we're currently working on #3304, so I will start incorporating your suggestions there first. Some of the files (.iuml) are going to be reused in the other PlantUML diagrams once merged and rebased. Also, I think you mentioned that downstream expects sentence-case for the text in steps, so I'm going to apply that as well. Thank you for your review, much appreciated! |
@Lennonka Seeing the rendered PNG file is not the same as seeing it in an .adoc file. If there is no good place to include this diagram, I recommend that you create a temporary .adoc file and embed it in an assembly (with lots of warnings that this is for review purposes only) so that we can see how a diagram of this size renders on the page. The text might be too small to read. |
|
@stejskalleos GH won't let me assign you as a reviewer to this PR, so I'm tagging you :) PS. I didn't manage to incorporate comments from previous PRs yet. |
Lennonka
force-pushed
the
provisioning-diagram-bootdisk-subnet
branch
from
2ff6914
to
20129f9
Compare
|
Initial feedback incorporated. cc @stejskalleos |
What changes are you introducing?
Adding a sequence diagram of installer-based provisioning with subnet bootdisk. Using PlantUML to build the diagram.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
Preparation for improvements of Provisioning hosts. The diagram will be used later to explain the workflow of the provisioning method.
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Checklists
Please cherry-pick my commits into: N/A