Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add diagram of image-based provisioning with finish #3307

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add diagram of image-based provisioning with finish #3307

wants to merge 2 commits into from

Conversation

Lennonka
Copy link
Contributor

What changes are you introducing?

Adding a sequence diagram of image-based provisioning with Finish script. Using PlantUML to build the diagram.

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Preparation for improvements of Provisioning hosts. The diagram will be used later to explain the workflow of the provisioning method.

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

  • Some files (.iuml, .pstyle) are expected to be reused in mutiple diagrams.
  • Puppet steps are not currenly displayed in the resulting image. Perhaps they should be for Foreman?
  • Continuation of Add diagrams of provisioning methods #3069

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into: N/A

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 20, 2024 •
edited
Loading

The PR preview for 9f149fb is available at theforeman-foreman-documentation-preview-pr-3307.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

@Lennonka Lennonka added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective labels Sep 20, 2024
@Lennonka Lennonka marked this pull request as draft October 8, 2024 13:36
@Lennonka Lennonka force-pushed the provisioning-diagram-image-finish branch from eecfeae to 9f149fb Compare November 13, 2024 19:10
@Lennonka
Copy link
Contributor Author

Rebased and initial feedback incorporated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs style review Requires a review from docs style/grammar perspective Needs tech review Requires a review from the technical perspective
Projects
None yet
Milestone
Beginner-friendly provisioning guide
Development

Successfully merging this pull request may close these issues.
2 participants
@Lennonka @maximiliankolb