Skip to content

Commit

Permalink
Don't scan common symlinks and use github-pr-annotations
Browse files Browse the repository at this point in the history
We have an excessive symlink farm pointint at guides/common, vale
rescans that every time when scanning the individual guides, which makes
it super slow (35min on my laptop), excluding the links in guides/doc-*
makes it quite fast (90sec on my latop) as it now only scans
guides/common once.

Also exclicitly use the github-pr-annotations reporter, which works w/o
elevated GITHUB_TOKEN privileges and thus also from forked repos.
  • Loading branch information
evgeni committed Jul 18, 2024
1 parent 975a305 commit 2ce46e7
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions .github/workflows/lint-with-vale.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,9 @@ jobs:
- uses: errata-ai/vale-action@reviewdog
with:
filter_mode: diff_context
vale_flags: "--no-exit --minAlertLevel=error"
reporter: github-pr-review
vale_flags: "--no-exit --minAlertLevel=error --glob=!*/doc-*/common/*"
# github-pr-annotations doesn't require elevated token privileges
reporter: github-pr-annotations
fail_on_error: true
env:
# Required, set by GitHub actions automatically:
# https://docs.github.com/en/actions/security-guides/automatic-token-authentication#about-the-github_token-secret
GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
REVIEWDOG_GITHUB_API_TOKEN: ${{secrets.GITHUB_TOKEN}}
# let's limit this a bit
files: guides/

0 comments on commit 2ce46e7

Please sign in to comment.