Oral-B Bluetooth Toothbrush #440
Conversation
Initial submission of Oral-B Bluetooth Toothbrush decoder
| {"Oral-B", "Oral-B", "dc0004710502360000000f0004"}, | ||
| {"Oral-B", "Oral-B", "dc000471050332010301030a04"}, | ||
| {"Oral-B", "Oral-B", "dc00047105013a000002010004"}, | ||
| {"Oral-B", "Oral-B", "dc000471050432010e03032e04"}, | ||
| {"Oral-B", "Oral-B", "dc000471057332010e05032e04"}, | ||
| {"Oral-B", "Oral-B", "dc000471050332010e06032e04"}, | ||
| {"Oral-B", "Oral-B", "dc000471050332010e07032e04"}, | ||
| {"Oral-B", "Oral-B", "dc000471050332010e08032e04"}, | ||
| {"Oral-B", "Oral-B", "dc000202060220000001010004"}, | ||
| {"Oral-B", "Oral-B", "dc000202067320020f07080004"}, |
There was a problem hiding this comment.
These are fine though as they only specify the test name and device braodcast name, with the latter not relevant for this decoder.
| "{\"brand\":\"Oral-B\",\"model\":\"BT Toothbrush\",\"model_id\":\"OralB_BT\",\"type\":\"BODY\",\"state\":\"idle\",\"mode\":\"off\",\"pressure\":54,\"time\":0}", | ||
| "{\"brand\":\"Oral-B\",\"model\":\"BT Toothbrush\",\"model_id\":\"OralB_BT\",\"type\":\"BODY\",\"state\":\"running\",\"mode\":\"daily clean\",\"sector\":\"sector 3\",\"pressure\":50,\"time\":63}", | ||
| "{\"brand\":\"Oral-B\",\"model\":\"BT Toothbrush\",\"model_id\":\"OralB_BT\",\"type\":\"BODY\",\"state\":\"initialising\",\"mode\":\"sensitive\",\"sector\":\"sector 1\",\"pressure\":58,\"time\":0}", | ||
| "{\"brand\":\"Oral-B\",\"model\":\"BT Toothbrush\",\"model_id\":\"OralB_BT\",\"type\":\"BODY\",\"state\":\"charging\",\"mode\":\"massage\",\"sector\":\"sector 3\",\"pressure\":50,\"time\":74}", | ||
| "{\"brand\":\"Oral-B\",\"model\":\"BT Toothbrush\",\"model_id\":\"OralB_BT\",\"type\":\"BODY\",\"state\":\"sleeping\",\"mode\":\"deep clean\",\"sector\":\"sector 3\",\"pressure\":50,\"time\":74}", | ||
| "{\"brand\":\"Oral-B\",\"model\":\"BT Toothbrush\",\"model_id\":\"OralB_BT\",\"type\":\"BODY\",\"state\":\"running\",\"mode\":\"tongue cleaning\",\"sector\":\"sector 3\",\"pressure\":50,\"time\":74}", | ||
| "{\"brand\":\"Oral-B\",\"model\":\"BT Toothbrush\",\"model_id\":\"OralB_BT\",\"type\":\"BODY\",\"state\":\"running\",\"mode\":\"turbo\",\"sector\":\"sector 3\",\"pressure\":50,\"time\":74}", | ||
| "{\"brand\":\"Oral-B\",\"model\":\"BT Toothbrush\",\"model_id\":\"OralB_BT\",\"type\":\"BODY\",\"state\":\"running\",\"sector\":\"sector 3\",\"pressure\":50,\"time\":74}", | ||
| "{\"brand\":\"Oral-B\",\"model\":\"BT Toothbrush\",\"model_id\":\"OralB_BT\",\"type\":\"BODY\",\"state\":\"idle\",\"mode\":\"daily clean\",\"sector\":\"sector 1\",\"pressure\":32,\"time\":0}", | ||
| "{\"brand\":\"Oral-B\",\"model\":\"BT Toothbrush\",\"model_id\":\"OralB_BT\",\"type\":\"BODY\",\"state\":\"sleeping\",\"mode\":\"turbo\",\"sector\":\"sector 8\",\"pressure\":32,\"time\":135}", |
There was a problem hiding this comment.
Same for the model_ids here
| { | ||
| "brand":"Oral-B", | ||
| "model":"BT Toothbrush", | ||
| "model_id":"OralB_BT", |
There was a problem hiding this comment.
The model_id would need to be all caps as well
| @@ -118,6 +118,7 @@ class TheengsDecoder { | |||
| ABN07, | |||
| ABTEMP, | |||
| AMPHIRO, | |||
| OralB_BT, | |||
There was a problem hiding this comment.
This should probably be in all caps for consistency.
|
Ah, seems I wasn't quick enough to get my comments in before it was merged |
|
I suppose so ;) that's what you get digging out ancient decoder trials and focusing more on the functionality than consistency. Thanks for pointing it out! :) will sort it in a new commit |
|
Hahaha, yeah I've done that myself a few times. I've got one of these brushes myself, so it's nice to see someone adding a decoder for it |
|
The decoder might still require some refinements in the future, especially with so many different Oral-B model around. If you find any issues or suggestions for additions with your model in the future any comments will be appreciated. |
Initial submission of Oral-B Bluetooth Toothbrush decoder
Checklist: