Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APEX-1562 - send welcome message to birthday squad #26

Merged
merged 8 commits into from
Nov 17, 2023
Merged

APEX-1562 - send welcome message to birthday squad #26

merged 8 commits into from
Nov 17, 2023

Conversation

BaDo2001
Copy link
Contributor

@BaDo2001 BaDo2001 commented Nov 17, 2023 •
edited
Loading

Issue: https://apexlab.atlassian.net/browse/APEX-1562

  • collects icebreaker threads and presentIdeas and sends it to the birthday squad conversation
  • fixes issue with multiple pr-s deploying same rule for default event bus
  • adds manual testing for createSquad

debrecenid
debrecenid suggested changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@debrecenid debrecenid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comment, and also unit tests are missing. The integration test are so complex, but i gues some unit test would be nice, the catch the erorrs early on, and for the other functions we also have both kind of tests.

packages/core/services/slack/constructBirthdaySquadWelcomeMessage.ts Outdated Show resolved Hide resolved
packages/core/types/schedule/index.ts Outdated Show resolved Hide resolved
packages/core/types/cron/index.ts Outdated Show resolved Hide resolved
tests/integration/askPresentAndSquadJoin.test.ts Show resolved Hide resolved
tests/integration/welcomeMessage.test.ts Outdated Show resolved Hide resolved
packages/core/services/slack/constructBirthdaySquadWelcomeMessage.ts Show resolved Hide resolved
@BaDo2001 BaDo2001 merged commit a1d4f90 into main Nov 17, 2023
3 checks passed
@BaDo2001 BaDo2001 deleted the APEX-1562-welcome-message branch November 17, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@debrecenid debrecenid debrecenid approved these changes

@attilazsoltdanku attilazsoltdanku Awaiting requested review from attilazsoltdanku

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BaDo2001 @debrecenid