Bump Dependency Bounds & Fix Test Suite #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 4, 2024
|
Also fixes #12 |
the-real-blackh
approved these changes
Sep 7, 2024
|
Thanks & welcome back! Can we get this merged in? I got hackage maintainer permission while you were away so I could keep the dependencies up to date. If you're willing to make me a collaborator on this repo, I can make sure the version bounds in here are kept up to date as well. I haven't poked deep enough to make any actual useful code changes though 😅 |
|
Updated for newly released deepseq 1.6 |
|
Hi @prikhi, happy to make you a maintainer on Hackage. What's your username on Hackage? |
|
Thanks! Had the hackage trustees add me as a hackage maintainer already when dependencies broke. |
|
Thank you for doing this. |
|
No problem, happy to keep this working, few of my projects use it via transitive dependencies. Thank you for building it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension of #13
Bump deepseq to support 1.5.0.0, fix compilation error in test suite.
Tested builds with
stack build --resolver nightly-2024-02-04&cabal build -w ghc-9.8 --constraint='deepseq==1.5.0.0Test-suite passed with
stack run --resolver ngihtly-2024-02-04&cabal run -w ghc-9.8 --constraint='deepseq==1.5.0.0'intest/directory.