Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): create icon package for using google font icons #15

Merged
merged 5 commits into from
Jan 19, 2025

Conversation

arashagp
Copy link
Member

@arashagp arashagp commented Jan 18, 2025

Description

Tasks

Code & Documentation:

  • 📝 Self-Review: Thoroughly review your code changes.
  • 📚 Code Documentation: Update/create all necessary in-code documentation.
  • 📖 User Guides (If Applicable): Add necessary guides to README or other help files.
  • 🎨 Formatting: Ensure code is properly formatted.

Project Management & Tracking:

  • 📅 Daily Report (If Applicable): Record changes in the company's daily report.
  • ⬆️ GitHub Management: Ensure PR is assigned, added to the correct project, and has appropriate labels. Confirm it adheres to the single purpose principle.
  • 🏷️ Set Label: Select and apply the appropriate label(s) for this pull request (e.g., bug, feature, enhancement, documentation). This helps categorize and track the changes.
  • 🎯 Single Purpose PR: Confirm this PR addresses a single, well-defined change.

Deployment & Testing (If Applicable):

  • 🔄 Rebase: Ensure your branch is rebased and updated.
  • Local Deployment Testing: Deploy and test locally if changes affect functionality.

@arashagp arashagp self-assigned this Jan 18, 2025
@arashagp arashagp requested a review from njfamirm as a code owner January 18, 2025 05:23
@arashagp arashagp added the new-feature New features or options. label Jan 18, 2025
Copy link
Member

@njfamirm njfamirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

لطفا اگه کامل متوجه همه قسمت ها شدی و به نظرت آماده بود بگو

packages/icons/style/main.css Outdated Show resolved Hide resolved
packages/icons/style/main.css Outdated Show resolved Hide resolved
packages/icons/style/main.css Outdated Show resolved Hide resolved
packages/icons/package.json Outdated Show resolved Hide resolved
packages/icons/package.json Outdated Show resolved Hide resolved
packages/icons/README.md Outdated Show resolved Hide resolved
packages/icons/font/material-icon-font-outlined.woff Outdated Show resolved Hide resolved
packages/icons/package.json Outdated Show resolved Hide resolved
packages/icons/font/material-icon-font-outlined.woff Outdated Show resolved Hide resolved
packages/icons/README.md Outdated Show resolved Hide resolved
packages/icons/README.md Outdated Show resolved Hide resolved
njfamirm
njfamirm previously approved these changes Jan 19, 2025
@arashagp arashagp merged commit 4620911 into next Jan 19, 2025
2 checks passed
@arashagp arashagp deleted the feat/icons branch January 19, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature New features or options.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants