query: Support chain deduplication algorithm #7808
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can run I wonder if we want to add a small paragraph in the query docs that explains when to use which dedup algorithm. |
lachruzam
force-pushed
the
query-with-chain-dedup
branch
from
73ce145
to
ed4edbc
Compare
fpetkovski
previously approved these changes
Oct 15, 2024
pedro-stanaka
approved these changes
Oct 15, 2024
|
Can I somehow rerun e2e tests? They worked before the rebase and also locally on my laptop, so I suspect that fails are due to flaky tests. |
|
It seems to consistently fail on other PRs too, so it's unrelated to this change. |
Signed-off-by: Michał Mazur <[email protected]>
Signed-off-by: Michał Mazur <[email protected]>
lachruzam
force-pushed
the
query-with-chain-dedup
branch
from
ed4edbc
to
04502d7
Compare
|
Sorry for nudging again, but I'm lost how to handle flakes here (these are my first PRs to thanos). |
fpetkovski
approved these changes
Oct 18, 2024
|
I bumped the CI and everything is green now. I'll leave some time for others to take a look before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds --deduplication.func flag to query command.
All tests should work properly, however this PR isn't properly polished, yet.