Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakout Room 12: Update main.py #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

tgoslee
Copy link
Owner

@tgoslee tgoslee commented May 10, 2022

No description provided.

Copy link
Collaborator

@jaekerrclayton jaekerrclayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggestions about refactoring code, consider consolidating variables.

@@ -1 +1,23 @@
#Mad Libs Generator Project
//Loop back to this point once code finishes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use proper python formatting for comments with either ''' or #

//Loop back to this point once code finishes
loop = 1
while (loop < 9):
// All the questions that the program asks the user
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see first comment

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment about creating a function (either dict or array to access variables)

place = input("Name a place: ")
adjective = input("Choose an adjective (Describing word): ")
third_noun = input("Choose a noun: ")
// Displays the story based on the users input
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see first comment

print ("You may think that is this the",third_noun,",")
print ("Well it is.")
print ("------------------------------------------")
// Loop back to "loop = 1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see first comment

// Displays the story based on the users input
print ("------------------------------------------")
print ("Be kind to your",noun,"- footed", plural_noun)
print ("For a duck may be somebody's", seond_noun,",")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seond_noun typo! reads as undefined / runs error

@@ -1 +1,23 @@
#Mad Libs Generator Project
//Loop back to this point once code finishes
loop = 1
while (loop < 9):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

current while loop will generate the program 8 times (loop could start at 0, while loop < 10)

@@ -1 +1,23 @@
#Mad Libs Generator Project
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider creating a dictionary of inputs/print statements for your formatting. Potentially consider creating a function for better readability/manipulation of code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants