Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakout Room 2: Update main.py #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Breakout Room 2: Update main.py #2

wants to merge 1 commit into from

Conversation

tgoslee
Copy link
Owner

@tgoslee tgoslee commented May 10, 2022

No description provided.

@@ -1 +1,23 @@
#Mad Libs Generator Project
//Loop back to this point once code finishes
loop = 1
while (loop < 9):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using a for loop here since we know how many times this needs to run.

// Displays the story based on the users input
print ("------------------------------------------")
print ("Be kind to your",noun,"- footed", plural_noun)
print ("For a duck may be somebody's", seond_noun,",")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check you spelling of your variables.

Comment on lines +13 to +21
print ("------------------------------------------")
print ("Be kind to your",noun,"- footed", plural_noun)
print ("For a duck may be somebody's", seond_noun,",")
print ("Be kind to your",plural_noun,"in",place)
print ("Where the weather is always",adjective,".")
print ()
print ("You may think that is this the",third_noun,",")
print ("Well it is.")
print ("------------------------------------------")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider reformatting the print statements using triple quote f string.

Comment on lines +6 to +11
noun = input("Choose a noun: ")
plural_noun = input("Choose a plural noun: ")
second_noun = input("Choose a noun: ")
place = input("Name a place: ")
adjective = input("Choose an adjective (Describing word): ")
third_noun = input("Choose a noun: ")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A data structure or hash table could do well here.

@@ -1 +1,23 @@
#Mad Libs Generator Project
//Loop back to this point once code finishes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 2, 5, 12, and 22 -- // is not the correct commenting symbol for python.

@@ -1 +1,23 @@
#Mad Libs Generator Project
//Loop back to this point once code finishes
loop = 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines 2-3 and 22-23 not needed with for loop.

print ("Well it is.")
print ("------------------------------------------")
// Loop back to "loop = 1"
loop = loop + 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed with for loop

@@ -1 +1,23 @@
#Mad Libs Generator Project
//Loop back to this point once code finishes
loop = 1
while (loop < 9):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future reference ensure your counter will give you your desired results.
while (loop < 9) will only iterate 8 times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants