Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakout Room 10: Update main.py #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Breakout Room 10: Update main.py #10

wants to merge 1 commit into from

Conversation

tgoslee
Copy link
Owner

@tgoslee tgoslee commented May 10, 2022

No description provided.

Copy link
Collaborator

@tiffinihyatt tiffinihyatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Trenisha! We left some comments on your code. Feel free to reach out with any questions!

Comment on lines +6 to +11
noun = input("Choose a noun: ")
plural_noun = input("Choose a plural noun: ")
second_noun = input("Choose a noun: ")
place = input("Name a place: ")
adjective = input("Choose an adjective (Describing word): ")
third_noun = input("Choose a noun: ")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider moving user input collection into a helper function and storing the values in a data structure (e.g., dictionary).

Comment on lines +13 to +21
print ("------------------------------------------")
print ("Be kind to your",noun,"- footed", plural_noun)
print ("For a duck may be somebody's", seond_noun,",")
print ("Be kind to your",plural_noun,"in",place)
print ("Where the weather is always",adjective,".")
print ()
print ("You may think that is this the",third_noun,",")
print ("Well it is.")
print ("------------------------------------------")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate that your print statements are easy to read (and not one long line). Consider defining a function to construct the story and using an f string to consolidate these print statements.

Comment on lines +3 to +4
loop = 1
while (loop < 9):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we know that we will have 10 rounds of gameplay, consider using a for loop here. It may also be helpful to use a more explicit variable name than "loop".

If you want to keep a while loop, the conditional loop will need to be while(loop < 11) to ensure the game repeats 10 times.

// Displays the story based on the users input
print ("------------------------------------------")
print ("Be kind to your",noun,"- footed", plural_noun)
print ("For a duck may be somebody's", seond_noun,",")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

print ("For a duck may be somebody's", second_noun,",")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants