-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breakout Room 10: Update main.py #10
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Trenisha! We left some comments on your code. Feel free to reach out with any questions!
noun = input("Choose a noun: ") | ||
plural_noun = input("Choose a plural noun: ") | ||
second_noun = input("Choose a noun: ") | ||
place = input("Name a place: ") | ||
adjective = input("Choose an adjective (Describing word): ") | ||
third_noun = input("Choose a noun: ") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider moving user input collection into a helper function and storing the values in a data structure (e.g., dictionary).
print ("------------------------------------------") | ||
print ("Be kind to your",noun,"- footed", plural_noun) | ||
print ("For a duck may be somebody's", seond_noun,",") | ||
print ("Be kind to your",plural_noun,"in",place) | ||
print ("Where the weather is always",adjective,".") | ||
print () | ||
print ("You may think that is this the",third_noun,",") | ||
print ("Well it is.") | ||
print ("------------------------------------------") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate that your print statements are easy to read (and not one long line). Consider defining a function to construct the story and using an f string to consolidate these print statements.
loop = 1 | ||
while (loop < 9): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we know that we will have 10 rounds of gameplay, consider using a for loop here. It may also be helpful to use a more explicit variable name than "loop".
If you want to keep a while loop, the conditional loop will need to be while(loop < 11)
to ensure the game repeats 10 times.
// Displays the story based on the users input | ||
print ("------------------------------------------") | ||
print ("Be kind to your",noun,"- footed", plural_noun) | ||
print ("For a duck may be somebody's", seond_noun,",") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
print ("For a duck may be somebody's", second_noun,",")
No description provided.