-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breakout Room 1: Update main.py #1
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. Now do it again :)
// All the questions that the program asks the user | ||
noun = input("Choose a noun: ") | ||
plural_noun = input("Choose a plural noun: ") | ||
second_noun = input("Choose a noun: ") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest distinguishing that the user enters a 'second' noun, so they don't think it is a repeat or error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider creating a helper function to manage the repeated request for a noun.
second_noun = input("Choose a noun: ") | ||
place = input("Name a place: ") | ||
adjective = input("Choose an adjective (Describing word): ") | ||
third_noun = input("Choose a noun: ") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest distinguishing that the user enters a 'third' noun, so they don't think the prompt is a repeat or error.
// Displays the story based on the users input | ||
print ("------------------------------------------") | ||
print ("Be kind to your",noun,"- footed", plural_noun) | ||
print ("For a duck may be somebody's", seond_noun,",") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
***Misspelled 'second'
print ("Be kind to your",plural_noun,"in",place) | ||
print ("Where the weather is always",adjective,".") | ||
print () | ||
print ("You may think that is this the",third_noun,",") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect word order: 'this' and 'is' should be switched.
loop = 1 | ||
while (loop < 9): | ||
// All the questions that the program asks the user | ||
noun = input("Choose a noun: ") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the inputs are not properly validating entries. Check tests and for edge case inputs.
//Loop back to this point once code finishes | ||
loop = 1 | ||
while (loop < 9): | ||
// All the questions that the program asks the user |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider placing all input requests within a single function to create the desired output. A helper function could also be useful for repeated requestions.
adjective = input("Choose an adjective (Describing word): ") | ||
third_noun = input("Choose a noun: ") | ||
// Displays the story based on the users input | ||
print ("------------------------------------------") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider combing the print statements into a single print statement that is a formatted string containing each variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The print statement could be separated into individual lines for each phrase.
print ("Well it is.") | ||
print ("------------------------------------------") | ||
// Loop back to "loop = 1" | ||
loop = loop + 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactor to state: loop += 1
No description provided.