Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GrpcRuntime to PyMoose #1083

Merged
merged 14 commits into from
Jun 2, 2022
Merged

Add GrpcRuntime to PyMoose #1083

merged 14 commits into from
Jun 2, 2022

Conversation

mortendahl
Copy link
Member

@mortendahl mortendahl commented May 25, 2022 •
edited
Loading

This PR adds gRPC runtime bindings to PyMoose:

runtime = pm.GrpcMooseRuntime(
  role_assignment={
    "alice": "localhost:50000",
    "bob": "localhost:50001",
    "carole": "localhost:50002",
  }
)

results = runtime.evaluate_computation(my_computation)

Follow-up: #1090 #1089 #1094

@mortendahl mortendahl force-pushed the pymoose-grpc-choreography branch from f0363be to 13a6b7e Compare May 30, 2022 13:21
@mortendahl mortendahl requested a review from rdragos June 2, 2022 12:03
@mortendahl mortendahl changed the title [wip] Add GrpcRuntime to PyMoose Add GrpcRuntime to PyMoose Jun 2, 2022
@mortendahl mortendahl added this to the Release milestone Jun 2, 2022
rdragos
rdragos approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@rdragos rdragos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🎉

jvmncs
jvmncs approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@jvmncs jvmncs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mortendahl mortendahl merged commit e97303a into main Jun 2, 2022
@mortendahl mortendahl deleted the pymoose-grpc-choreography branch June 2, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvmncs jvmncs jvmncs approved these changes

@rdragos rdragos rdragos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release
Development

Successfully merging this pull request may close these issues.
3 participants
@mortendahl @rdragos @jvmncs