Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review PHP Pattern #40

Merged
merged 3 commits into from
Jun 2, 2023
Merged

Review PHP Pattern #40

merged 3 commits into from
Jun 2, 2023

Conversation

felix-20
Copy link
Contributor

@felix-20 felix-20 commented May 30, 2023

This PR includes a review of all PHP patterns. All patterns were manually looked at, php code was executed and spelling mistakes corrected. Additionally, the tpframework was used to run checkdiscoveryrules (to verify that the discovery rule works) and measure.
The following things should now be uniform across all patterns now:

  • Each pattern:
    • has a description located in ./docs/description.md
    • has a uniform README file, including the measurements done in 06/2021, 05/2023 and the results of checkdiscoveryrules
  • Each instance:
    • has an instance description
    • has a correct source and sink line (as comment in the php file and in the json file)
    • has a bash file containing the opcode of that pattern
  • Most instances:

Patterns 6 (#36), 45 (#37), 47 (#35), 75 (#38) and 83 (#39) are not included in this PR, as they have larger changes. The PR including these patterns can be found #41

Copy link
Contributor

@compaluca compaluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot @felix-20 ! Please add specific issues (if not done yet) for the patterns where problems are experienced:

  • Exceptions - cpg generation fails: Pattern 19
  • Exceptions - could profit from source code discovery (?): Pattern 5, 40, 55, 47, 48, 80

@compaluca compaluca merged commit 4a0d0f9 into master Jun 2, 2023
@compaluca compaluca deleted the review-php-patterns branch June 2, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants