feat: calculate fee when simulating tx #127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honeymaro
commented
Jun 9, 2022
•
honeymaro
commented
- Resolved Advanced fee calculation #126
- Clear selected assets when the user changes the network. - Resolved #112
v2 -> main
refactor: remove fcd & temp fee
fix: tx result
fix: custom slippage setting on mobile
feat: CD app, classic, app-dev
honeymaro
requested review from
jhlee-young,
psy2848048,
caramis,
jbamlee and
JoowonYun
psy2848048
approved these changes
Jun 9, 2022
|
@honeymaro max button doesn't work. |
JoowonYun
requested changes
Jun 9, 2022
jhlee-young
reviewed
Jun 15, 2022
| ? value | ||
| .dp( | ||
| config?.dp ?? | ||
| (config?.integer ? 0 : value.gte(e) ? 2 : dp(contract_addr)), |
There was a problem hiding this comment.
can we replace line 48 to use dp func and put decimals here? 🤔
JoowonYun
reviewed
Jun 16, 2022
| value1, | ||
| value2, | ||
| }, | ||
| { gasAdjustment: 2 } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.