[IMPL] Added MiniDumpWriteDump and MINIDUMP_TYPE manually. #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason the ClangSharpPInvokeGenerator tool skips MiniDumpWriteDump and the MINIDUMP_TYPE enum so for now add them back manually until dotnet/ClangSharp#571 is fixed. Also this maps the last 3 parameters to the function to void* pointers to make the application developer responsible for providing the types to pass in to them if they want to provide them, otherwise they can pass null as usual. Signed-off-by: AraHaan <[email protected]>
AraHaan
commented
Sep 4, 2024
tannergooding
requested changes
Sep 10, 2024
There was a problem hiding this comment.
As per dotnet/ClangSharp#571 you need to explicitly handle each header, namely by adding the right files to handle um/mionidumpset.h here: https://github.com/terrafx/terrafx.interop.windows/tree/main/generation/Windows/um
Signed-off-by: AraHaan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the ClangSharpPInvokeGenerator tool skips MiniDumpWriteDump and the MINIDUMP_TYPE enum so for now add them back manually until dotnet/ClangSharp#571 is fixed.
Also this maps the last 3 parameters to the function to void* pointers to make the application developer responsible for providing the types to pass in to them if they want to provide them, otherwise they can pass null as usual.
implements: #398
Checklist: