Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Establish a dedicated "NIST Mode" for easing compliance #275

Closed
wants to merge 5 commits into from

Conversation

apmarshall
Copy link

Description

This PR introduces a new variable, nist_mode, which, when set to true overrides other variables within the module to guarantee certain values for compliance purposes.

In the context of this module, the changes made can be seen in the updates to the README, which documents both what requirements are being met and what variables are overridden to achieve this.

Motivation and Context

There are some environments, especially those in the government space, where adherence to NIST SP 800-53 standards is required. Rather than creating separate modules that enforce these requirements, this allows users in those environments to continue using these community supported modules by setting a single variable to ensure compliance requirements are met.

Breaking Changes

This should not introduce any breaking changes to uses who do not enable nist_mode. The default for nist_mode is set to false, which means that the module should continue to perform exactly as it currently does for users who have not enabled nist_mode. Enabling nist_mode overrides certain variables, as documented in the README, which could result in breaking changes for module implementations that would have been out of compliance before setting nist_mode to true.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@antonbabenko
Copy link
Member

Thank you for expressing interest. Closing for the same reasons as terraform-aws-modules/terraform-aws-kms#29 .

PS: Shameless plug... https://compliance.tf is in development.

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants