Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct mis-spelling in serverless security policy default description #16

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

dim-ops
Copy link
Contributor

@dim-ops dim-ops commented Jun 28, 2024

Description

Spelling error. Newtwork => network

@dim-ops dim-ops changed the title fix: description network policy fix: Description network policy Jun 28, 2024
@@ -64,7 +64,7 @@ resource "aws_opensearchserverless_security_policy" "encryption" {
resource "aws_opensearchserverless_security_policy" "network" {
count = var.create && var.create_network_policy ? 1 : 0

description = coalesce(var.network_policy_description, "Newtwork policy for ${var.name} collection")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know - Newtwork sounds kinda cool 😅

Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@bryantbiggs bryantbiggs changed the title fix: Description network policy fix: Correct mis-spelling in serverless security policy default description Jun 28, 2024
@bryantbiggs bryantbiggs merged commit 844a435 into terraform-aws-modules:master Jun 28, 2024
9 of 10 checks passed
antonbabenko pushed a commit that referenced this pull request Jun 28, 2024
## [1.2.2](v1.2.1...v1.2.2) (2024-06-28)

### Bug Fixes

* Correct mis-spelling in serverless security policy default description ([#16](#16)) ([844a435](844a435))
@antonbabenko
Copy link
Member

This PR is included in version 1.2.2 🎉

@dim-ops
Copy link
Contributor Author

dim-ops commented Jun 28, 2024

@antonbabenko I hesitate to take the time to add the creation of the VPC endpoint to the module, what do you think? https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/opensearch_vpc_endpoint

@bryantbiggs
Copy link
Member

bryantbiggs commented Jun 28, 2024

That would go in the VPC module

Scratch that - that implementation would go here but we already have it in the module

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants