Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2.10): upgrade handler #275

Merged
merged 5 commits into from
Mar 7, 2024
Merged

Conversation

emidev98
Copy link
Contributor

@emidev98 emidev98 commented Mar 6, 2024

Fixes a typo for the upgrade handler

It's okay that the codecov does not work because we don't cover empty upgrde handlers

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 70.41%. Comparing base (0f41b7f) to head (cdc7ac0).
Report is 1 commits behind head on release/v2.10.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release/v2.10     #275      +/-   ##
=================================================
- Coverage          70.50%   70.41%   -0.09%     
=================================================
  Files                 45       45              
  Lines               2092     2096       +4     
=================================================
+ Hits                1475     1476       +1     
- Misses               451      453       +2     
- Partials             166      167       +1     
Files Coverage Δ
app/upgrade_handler.go 76.04% <33.33%> (-2.22%) ⬇️

@emidev98 emidev98 changed the title fix: upgrade handler fix(v2.10): upgrade handler Mar 6, 2024
@javiersuweijie javiersuweijie merged commit 7dce06b into release/v2.10 Mar 7, 2024
7 of 8 checks passed
@emidev98 emidev98 deleted the fix/v2.10/upgrade/hanlder branch March 7, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants