feat: implement simplified unbonding and rewards queries #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiersuweijie
requested changes
Feb 26, 2024
javiersuweijie
changed the base branch from
chore/v0.4.x/remove/deprecations
to
release/v0.4.x
proto/alliance/alliance/query.proto
Outdated
| @@ -249,7 +249,6 @@ message QueryAllianceUnbondingsByDelegatorResponse { | |||
| option (gogoproto.goproto_getters) = false; | |||
|
|
|||
| repeated UnbondingDelegation unbondings = 1 [(gogoproto.nullable) = false]; | |||
| cosmos.base.query.v1beta1.PageResponse pagination = 2; | |||
There was a problem hiding this comment.
Because we don't have a way to paginate that specific request and the amount of items to be recovered from the API is number_of_alliances * 7 (maximum undelegations)
|
@javiersuweijie the tests for the new API are added here:
If you want I can add more tests or I can try covering edge cases |
emidev98
force-pushed
the
chore/v0.4.x/queries
branch
from
332b882
to
a77d5aa
Compare
javiersuweijie
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the following issue #279 this PR implements a simplified way to query the unbondings and redelegations. It also includes tests and fixes for the other queries that does not return the right values.
These features were requested by @arthuryeti to simplify building frontends