feat(v0.4.x): unbond tokens when dissolving the alliance #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emidev98
changed the title
emidev98
changed the title
emidev98
force-pushed
the
feat/v0.4.x/unbond-on-delete
branch
from
7a7de12
to
989741b
Compare
…/alliance into feat/v0.4.x/unbond-on-delete
…/alliance into feat/v0.4.x/unbond-on-delete
…/alliance into feat/v0.4.x/unbond-on-delete
| if err != nil { | ||
| return nil, err | ||
| if asset.TotalTokens.GT(math.ZeroInt()) { | ||
| asset.IsDissolving = true |
There was a problem hiding this comment.
WHen deleting an asset, we should make it such that we disable the rewards as well. I'm thinking we set the reward weight to be zero.
There was a problem hiding this comment.
Hmm.... Good point!
| // the alliance has never had delegations or that all the delegations have been unbonded already, | ||
| // so going back to the line 52 of this file we avoid doing unnecessary comput. | ||
| if amountOfUndelegationsExecuted == 0 { | ||
| dereferencedAsset.IsInitialized = false |
There was a problem hiding this comment.
Here we should delete the alliance asset instead of setting IsInitialized to be false.
There was a problem hiding this comment.
@javiersuweijie shouldn't the alliance be deleted only when all the tokens have been unbonded?
…o feat/v0.4.x/unbond-on-delete
javiersuweijie
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request allow Alliances to be deleted even when there are still tokens staked. The flow starts when DeleteAllianceProposal is executed:
if there is no stake: it will just delete the alliance,else: will set the alliance to dissolving state.In the
ABCI#EndBlockerfromx/alliance: iterates the alliances in search of the ones with the dissolving flag enabled, when an alliance with the dissolving flag is found, all delegations are iterated matching the Denom of the delegation with the Denom of the alliance; when a match is found it will delegate that stake and assign to the alliance theallianceDissolutionTimeas the completion time of the unbonding.isInitialised property from alliance to false(the alliance will also not receive more rewards when the flag is set to false.