Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When client gets winner, restart button does not return client interface to voting #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nodkz
Copy link

@nodkz nodkz commented Oct 5, 2015

When all entries are voted and server return winner to clients, then a vote manager can not reset client interfaces via the reset button.
Because merge does not remove winner state from client state.
So before merge I add removing winner, and if it pass via server newState it correctly apply in client state.

PS. Thank you for this brilliant tutorial !! Very clearly and simple sentence writing, it is very comfortable to understand for the non-native english readers!

…ace to voting.

When all entries are voted and server return winner to clients, then a vote manager can not reset client interfaces via the reset button.
Because `merge` does not remove `winner` state from client state. 
So before merge I add removing `winner`, and if it pass via server newState it correctly apply in client state.

PS. Thank you for this brilliant tutorial !! Very clearly and simple sentence writing, it is very comfortable to understand for the non-native english readers!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant