Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re enable more not e2e xfail test cases #6947

Merged
merged 59 commits into from
Nov 1, 2024
Merged

Re enable more not e2e xfail test cases #6947

merged 59 commits into from
Nov 1, 2024

Conversation

nikelite
Copy link
Contributor

@nikelite nikelite commented Oct 29, 2024 •
edited
Loading

  • Exclude tests for the deprecated tfx/orchestration/experimental/core module from experimental orchestration.
  • Include additional testdata files in the package build.
  • Add module-level pytest cleanup functions for proto classes.
  • Update doc tests to clean up docs before execution.

nikelite added 30 commits October 9, 2024 13:08
@nikelite
Update nightly build to use recent nightly packages
a987571
@nikelite
Merge branch 'tensorflow:master' into master
23fb939
@nikelite
Adjust version constraints
b8e5e13
@nikelite
Merge branch 'master' of https://github.com/nikelite/tfx
9031f22
@nikelite
Adjust version constraints
d099fe7
@nikelite
Add pytest config to avoid absl.flags._exceptions.UnparsedFlagAccessE…
4942170 
…rror
@nikelite
Add pytest config to avoid absl.flags._exceptions.UnparsedFlagAccessE…
12327f6 
…rror
@nikelite
Revert "Add pytest config to avoid absl.flags._exceptions.UnparsedFla…
7e8d715 
…gAccessError"

This reverts commit 4942170.
@nikelite
Cleanup unused pytest import
8c15807
@nikelite
Cleanup unused pytest import
d9813bc
@nikelite
Add xFail for kfp handler test
8eb2958
@nikelite
Include components testdata to the package build to pass unit tests
e8c142c
@nikelite
revert dependencies change
725b8aa
@nikelite
Merge branch 'master' of https://github.com/nikelite/tfx into pytest
295b911
@nikelite
Include components testdata to the package build to pass unit tests
999351f
@nikelite
Add test constraints for unit-tests with nightly TFX libraries
1d0f92a
@nikelite
Update test constraints to use recent TFX libraries
e88e491
@nikelite
Merge branch 'master' of https://github.com/nikelite/tfx into pytest
f3f99f7
@nikelite
Merge branch 'tensorflow:master' into pytest
57c1a0e
@nikelite
update MANIFEST.in to include schema files
f104d60
@nikelite
Revert xfail cases which conftest cannot resolve
b3e6ae4
@nikelite
Merge branch 'tensorflow:master' into master
aa195cb
@nikelite
Merge branch 'pytest' of https://github.com/nikelite/tfx into pytest
5fa5403
@nikelite
Re-enable xfail tests
18e9de4
@nikelite
fix conflict
c595e39
@nikelite
Update vertex handler test to use mock_init inside the test function,…
0da5561 
… since mock decorator is not well working with pytest
@nikelite
Update pytest to use pytest-subprocess plugin
09b3bd1
@nikelite
Fix xfail cases from __subclasses__() which is not cleaned up with py…
60e630a 
…test
@nikelite
Fix lint errors
ccb4cf7
@nikelite
Revert subprocess install
12de42f
@keerthanakadiri keerthanakadiri self-assigned this Oct 29, 2024
@nikelite nikelite marked this pull request as ready for review November 1, 2024 03:45
smokestacklightnin
smokestacklightnin approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@smokestacklightnin smokestacklightnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as the tests do indeed pass (still waiting for them to run at the time of writing), then this PR has my approval.

@nikelite nikelite merged commit 9e66ed1 into tensorflow:master Nov 1, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smokestacklightnin smokestacklightnin smokestacklightnin approved these changes

Assignees

@keerthanakadiri keerthanakadiri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikelite @smokestacklightnin @keerthanakadiri