Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint errors #6944

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

smokestacklightnin
Copy link
Contributor

@smokestacklightnin smokestacklightnin commented Oct 27, 2024

The current linting workflow checks only for linting errors on a per pull request basis, rather than the entire repo. That is for a given pull request, the linting workflow only checks the files changed in that workflow. This is because there are many linting errors.

This pull request is a first effort fixing linting errors that predate the linting workflow.

Changes include:

  • Fix bugbear linting violations1
  • Fix ISC linting violations
  • Fix A linting violations
  • Fix LOG linting violations

Footnotes

  1. See Code inistantiates abstract base classes #6942, Abstract base classes have incorrectly decorated methods #6943, and Fixing Ruff function-call-in-default-argument (B008) causes test collection errors #6945 for remaining bugbear violations

@smokestacklightnin smokestacklightnin force-pushed the ci/linting/fix-lint-errors branch from bf43171 to bb24e15 Compare October 27, 2024 06:58
@keerthanakadiri keerthanakadiri self-assigned this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants