-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conftest.py to avoid absl.flags._exceptions.UnparsedFlagAccessError #6930
Conversation
…gAccessError" This reverts commit 4942170.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes don't look like they modify the pytest configuration - did I miss something here? Only looks like install constraints were changed.
Sorry for the confusion. I've added a conftest.py file that prevents the |
tfx/conftest.py
Outdated
from absl import flags | ||
|
||
def pytest_configure(config): | ||
del config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This deletes the pytest Config
object - how come this is needed here? Won't this destroy all pytest and pytest plugin configuration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I initially thought the config object was only used within the function, but to prevent potential issues, I've removed it. Thanks!
absl.flags._exceptions.UnparsedFlagAccessError