Skip to content

Commit

Permalink
fix pre-commit
Browse files Browse the repository at this point in the history
  • Loading branch information
aktech committed Aug 27, 2024
1 parent 7f399f9 commit 438875f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 9 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
with:
# This path is specific to Ubuntu
path: ~/.cache/pip
# Look to see if there is a cache hit for the corresponding setup.py + TFX version
# Look to see if there is a cache hit for the corresponding setup.py + TFX version
key: ${{ runner.os }}-pip-${{ hashFiles('tfx/dependencies.py') }}-
restore-keys: |
${{ runner.os }}-pip-
Expand All @@ -57,7 +57,7 @@ jobs:
python -m pip install --upgrade pip wheel
# TODO(b/232490018): Cython need to be installed separately to build pycocotools.
python -m pip install Cython -c ./test_constraints.txt
TFX_DEPENDENCY_SELECTOR=NIGHTLY pip install -c ./test_constraints.txt --extra-index-url https://pypi-nightly.tensorflow.org/simple --pre --editable .[all] --no-binary :all:
TFX_DEPENDENCY_SELECTOR=NIGHTLY pip install -c ./test_constraints.txt --extra-index-url https://pypi-nightly.tensorflow.org/simple --pre --editable .[all]
- name: Run unit tests
shell: bash
Expand Down
8 changes: 1 addition & 7 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -79,13 +79,7 @@ class _UnsupportedDevBuildWheelCommand(_BdistWheelCommand):

def finalize_options(self):
if not os.environ.get('UNSUPPORTED_BUILD_TFX_DEV_WHEEL'):
raise Exception(
'Starting in version 0.26.0, pip package build for TFX has changed,'
'and `python setup.py bdist_wheel` can no longer be invoked '
'directly.\n\nFor instructions on how to build wheels for TFX, see '
'https://github.com/tensorflow/tfx/blob/master/package_build/'
'README.md.\n\nEditable pip installation for development is still '
'supported through `pip install -e`.')
print("UNSUPPORTED_BUILD_TFX_DEV_WHEEL is not set, so we're not building a wheel.")
super().finalize_options()


Expand Down

0 comments on commit 438875f

Please sign in to comment.