MDCMigration: Update mat-slider in RangeInputComponent #6659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesHollyer
changed the title
JamesHollyer
force-pushed
the
MigrateRangeSelectorSlider
branch
8 times, most recently
from
0ed5525 to
26a84b1
Compare
JamesHollyer
force-pushed
the
MigrateRangeSelectorSlider
branch
from
26a84b1 to
9c1cd68
Compare
rileyajones
approved these changes
Oct 25, 2023
| @@ -43,23 +35,6 @@ enum Position { | |||
| * | |||
| * Anatomy of the component: | |||
| * | |||
| * Single slider: | |||
There was a problem hiding this comment.
👏 The logic was complicated enough to warrant a JSDoc diagram and you got to remove it all
Co-authored-by: Riley Jones <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
This update to the new Angular Materials is a mandate from Angular. Furthermore this RangeInputComponent was kind a a mess with lots of somewhat hacky custom code. The new mat-slider handles all of that for us so this is also a big cleanup.
Technical description of changes
The RangeInputComponent is no longer used for single selection purposes so I removed that option. I also replaced the custom slider with a mat-slider and removed lots of tests that had to do without custom slider implementation.
Screenshots of UI changes (or N/A)
Alternate designs / implementations considered (or N/A)
I considered implementing this in the FilterDialog and the RunsTable and then deleting the RangeInputComponent entirely.