Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run e2e test for macOS #1138

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Conversation

nasnoisaac
Copy link
Contributor

close #1019

@muniu-bot
Copy link

muniu-bot bot commented Nov 1, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nasnoisaac
Once this PR has been reviewed and has the lgtm label, please assign terrytangyuan for approval by writing /assign @terrytangyuan in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaocegege
Copy link
Member

Thanks for your contribution! 🎉 👍

Run actions-ecosystem/action-get-latest-tag@v1
with:
semver_only: false
initial_version: v0.0.0
with_initial_version: true
env:
ENVD_ANALYTICS: false
Error: Container action is only supported on Linux

We may need a new action to get the latest tag.

@cutecutecat
Copy link
Member

cutecutecat commented Nov 24, 2022

For e2e-cli, the error is panic: test timed out after 20m0s:

Can be solved by revise:

envd/Makefile

Line 196 in ad6db6a

-race -v -timeout 20m -coverpkg=./pkg/... -coverprofile=e2e-cli-coverage.out ./e2e/cli

and

envd/Makefile

Line 205 in ad6db6a

-race -v -timeout 20m -coverpkg=./pkg/... -coverprofile=e2e-lang-coverage.out ./e2e/language

Or we can wait for them to let test be faster

For e2e-lang, the error is Connection reset by peer at conda install, it might be:

#20 39.80 ("Connection broken: ConnectionResetError(104, 'Connection reset by peer')", ConnectionResetError(104, 'Connection reset by peer'))
#20 39.80 
#20 39.80 
#20 ERROR: process "bash -c /opt/conda/bin/conda create -n envd python=3.9" did not complete successfully: exit code: 1

Maybe Intermittent HTTP error, run the action again can help.
ref:

@cutecutecat
Copy link
Member

e2e-lang problems seems like this:

  • error code 137 might be out of memory and process killed by system(not sure)
  • numpy running error is an unforeseen warning output OpenBLAS WARNING - could not determine the L2 cache size on this system, assuming 256k\n[2 3 4] , which could be hacked with contains([2 3 4])

But for e2e-cli, I think it's horrible to continue increasing the time limit to 60m and so on.

Maybe it's better to add a status/blocked label and wait for image optimization.

@nasnoisaac nasnoisaac changed the title run e2e test for macOS ci: run e2e test for macOS Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

feat(CI): Run e2e test for macOS
3 participants