Skip to content

Commit

Permalink
Fix: Remove unnecessary user switching code when installing R package (
Browse files Browse the repository at this point in the history
…#1351)

* Support installing R environment in DEB822 format

Signed-off-by: Botong Ou <[email protected]>

* Support installing R environment in DEB822 format

Signed-off-by: Botong Ou <[email protected]>

* Support installing R environment in DEB822 format

Signed-off-by: Botong Ou <[email protected]>

* Support installing R environment in DEB822 format

Signed-off-by: Botong Ou <[email protected]>

* Temporarily removed return error from installRLang

Signed-off-by: Botong Ou <[email protected]>

* Append to apt.conf

Signed-off-by: Botong Ou <[email protected]>

* Move apt configuration to a separate file /etc/apt/apt.conf.d/DEB822.conf

Signed-off-by: Botong Ou <[email protected]>

* Add comments and change some typos

Signed-off-by: Botong Ou <[email protected]>

* Adjust comments

Signed-off-by: Botong Ou <[email protected]>

* Adjust comments

Signed-off-by: Botong Ou <[email protected]>

* Fix typo

Signed-off-by: Botong Ou <[email protected]>

* Change to const

Signed-off-by: Botong Ou <[email protected]>

* Change to const

Signed-off-by: Botong Ou <[email protected]>

* Change internal message when install R environment

Signed-off-by: Botong Ou <[email protected]>

* Add e2e test for R language environment

Signed-off-by: Botong Ou <[email protected]>

* Format rlang/build.envd

Signed-off-by: Botong Ou <[email protected]>

* remove incorrect user-switching

Signed-off-by: Botong Ou <[email protected]>

* remove incorrect user-switching

Signed-off-by: Botong Ou <[email protected]>

Signed-off-by: Botong Ou <[email protected]>
  • Loading branch information
oubotong authored Dec 29, 2022
1 parent f18b194 commit bb0fe7c
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion pkg/lang/ir/v1/r.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ func (g generalGraph) installRPackages(root llb.State) llb.State {

// TODO(terrytangyuan): Support cache.
cmd := sb.String()
root = llb.User("envd")(root)
run := root.Run(llb.Shlex(cmd), llb.WithCustomNamef("install R packages"))
return run.Root()
}

0 comments on commit bb0fe7c

Please sign in to comment.