Fix bug in function decodeReflectJSONStruct

[NicolasMahe]

This PR fixes a bug in the function decodeReflectJSONStruct.

To decode each field of the struct, this function is calling decodeReflectJSON. The issue was instead of using each field.FieldOptions, it was passing its parameter fopts FieldOptions:

go-amino/json-decode.go

Line 416 in 59d50ef

err = cdc.decodeReflectJSON(valueBytes, finfo, frv, fopts)

The binary version decodeReflectBinaryStruct is already using each field.FieldOptions, so I just apply the same logic to the json version.

go-amino/binary-decode.go

Line 867 in 59d50ef

_n, err = cdc.decodeReflectBinary(bz, finfo, frv, field.FieldOptions, false)

I also add a new Unsafe struct to json_test.go to unit test the issue. Without the fix, the tests are failing.

---

Here is the link to the failed CI test before the fix: https://app.circleci.com/jobs/github/tendermint/go-amino/670

[melekes]

👍

[melekes]

is it possible to remove the last parameter? don't see a reason to keep it

[NicolasMahe]

yes it's possible. i didn't remove it because the binary version has it:

go-amino/binary-decode.go

Lines 763 to 764 in 59d50ef

	func (cdc *Codec) decodeReflectBinaryStruct(bz []byte, info *TypeInfo, rv reflect.Value,
	_ FieldOptions, bare bool) (n int, err error) {

[NicolasMahe]

updated 👍

[jacquesvcritien]

Are there plans for this to be merged please?

[melekes]

Are there plans for this to be merged please?

I don't think this repo is being maintained. Better to fork and continue from there.