Allow xdc and ndc tests in single test CI mode #6636
Conversation
.github/workflows/run-tests.yml
Outdated
| description: "Run a single unit test (INSTEAD of functional test)" | ||
| type: boolean | ||
| default: false | ||
| run_single_test_mode: |
There was a problem hiding this comment.
can this be a single 'enum' like choice?
like 'test_mode' with values
'all -fund-tests'
'single-func-test'
'single-unit-test'
etc.
I guess this will greatly simplify the logic below
There was a problem hiding this comment.
I tried to make an "all-tests" option that is the default test_mode and is used when the action is run for a PR, but the default behavior when the action is run for a PR is to make all the workflow_dispatch inputs empty, so inputs.test_mode was blank instead of the default all_tests option.
There may be a way to set it though.. I agree it would make the code much less annoying
…sts successful in single test mode
carlydf
changed the title
carlydf
force-pushed
the
cdf/flake-ci-tool
branch
from
db36d20
to
3d2ddfa
Compare
carlydf
changed the title
| @@ -1,5 +1,7 @@ | |||
| name: All Tests | |||
|
|
|||
| run-name: ${{ inputs.test_name }}${{ inputs.test_dbs }}${{ inputs.run_single_test_job }} | |||
There was a problem hiding this comment.
Does this need any delimiters to make it readable? How does it affect tests that aren't run in "single" mode?
|
|
||
| - run: make build-tests | ||
| if: ${{ inputs.run_single_test_job == '' }} |
| name: Unit test | ||
| needs: [pre-build, set-up-single-test] | ||
| strategy: | ||
| fail-fast: false | ||
| runs-on: ubuntu-20.04 | ||
| env: | ||
| BUILDKITE_MESSAGE: '{"job": "unit-test"}' |
| SINGLE_TEST_ARGS: ${{ needs.set-up-single-test.outputs.single_test_args }} | ||
| UNIT_TEST_DIR: ${{ inputs.unit_test_directory }} | ||
| TEST_TIMEOUT: ${{ needs.set-up-single-test.outputs.test_timeout }} |
There was a problem hiding this comment.
These aren't relevant anymore, they moved into the Run unit tests step. PTAL.
| env: | ||
| PERSISTENCE_TYPE: ${{ matrix.persistence_type }} | ||
| PERSISTENCE_DRIVER: ${{ matrix.persistence_driver }} | ||
| BUILDKITE_MESSAGE: '{"job": "functional-test-xdc", "db": "${{ matrix.persistence_driver }}"}' | ||
| TEST_TIMEOUT: ${{ needs.set-up-single-test.outputs.test_timeout }} |
There was a problem hiding this comment.
nit: Set this in Run functional test xdc so it's clear that it doesn't apply to the flaky test detection step.
What changed?
Why?
How did you test it?
Potential risks
Documentation
Is hotfix candidate?