Fix Windows CI binary build fix #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
changed the title
cretz
force-pushed
the
build-binary-windows-fix
branch
from
fcff268
to
01884fb
Compare
cretz
force-pushed
the
build-binary-windows-fix
branch
from
01884fb
to
29e1d1a
Compare
Quinn-With-Two-Ns
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Update the Temporal PYD file on Windows to the proper name after it got changed by a recent library update.
This seems to be caused by a setuptools-rust update (this comment explains what we're seeing and CI started failing on that release). Hopefully a wholesale update of our build processes in #398 will fix this.