SDK 2.7.0-beta #367
Merged
SDK 2.7.0-beta #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t Encoded header into Request object
…Workflow Client execution
refactor EncodedValues and EncodedHeader; init EncodedHeaderTestCase; fix Encoders, Input, Request; add Header into the ExecuteChildWorkflow command;
…nboundInterceptor, WorkflowOutboundInterceptor
…dInterceptor::execute()
…ing in workflow, use new Pipeline to run existing interceptors.
Simplify Instance class. Add ActivityName getter into `ExecuteActivity` command. Cleanup Instance and its children
Move internal classes into Internal namespace. Make Instance class more strict.
Co-authored-by: roxblnfk <[email protected]>
Co-authored-by: roxblnfk <[email protected]>
# Conflicts: # api/v1/GPBMetadata/Protocol.php # api/v1/Temporal/Roadrunner/Internal/Message.php # proto # resources/protocol.proto # src/Client/GRPC/ServiceClient.php # src/Internal/Declaration/WorkflowInstance.php # src/Internal/Workflow/Process/Process.php # src/Internal/Workflow/WorkflowContext.php # src/Worker/Transport/Codec/ProtoCodec/Decoder.php # tests/Fixtures/data/Test_ExecuteProtoWorkflow.log
…toJsonConverter` (#339)
# Conflicts: # src/Internal/Transport/Router/InvokeQuery.php # src/Internal/Transport/Router/InvokeSignal.php # src/Internal/Transport/Router/StartWorkflow.php # src/Internal/Workflow/ActivityStub.php # src/Internal/Workflow/ExternalWorkflowStub.php # src/Worker/Transport/Codec/JsonCodec/Decoder.php # src/Worker/Transport/Codec/ProtoCodec/Decoder.php # src/Worker/Transport/Codec/ProtoCodec/Encoder.php # src/Worker/Transport/Command/Command.php # src/Worker/Transport/Command/FailureResponse.php # src/Worker/Transport/Command/Request.php # src/Worker/Transport/Command/RequestInterface.php # src/Worker/Transport/Command/Response.php # src/Worker/Transport/Command/SuccessResponse.php # tests/Fixtures/data/Test_ActivityStubWorkflow.log # tests/Fixtures/data/Test_BatchedSignal.log # tests/Fixtures/data/Test_BatchedSignal_01.log # tests/Fixtures/data/Test_BinaryPayload.log # tests/Fixtures/data/Test_CancelledMidflightWorkflow.log # tests/Fixtures/data/Test_CancelledNestedWorkflow.log # tests/Fixtures/data/Test_CancelledWithCompensationWorkflow.log # tests/Fixtures/data/Test_ContinueAsNew.log # tests/Fixtures/data/Test_EmptyWorkflow.log # tests/Fixtures/data/Test_ExecuteChildStubWorkflow.log # tests/Fixtures/data/Test_ExecuteChildStubWorkflow_02.log # tests/Fixtures/data/Test_ExecuteChildWorkflow.log # tests/Fixtures/data/Test_ExecuteProtoWorkflow.log # tests/Fixtures/data/Test_ExecuteSimpleDTOWorkflow.log # tests/Fixtures/data/Test_ExecuteSimpleWorkflowWithSequenceInBatch.log # tests/Fixtures/data/Test_ExecuteSimpleWorkflow_1.log # tests/Fixtures/data/Test_ExecuteWorkflowWithParallelScopes.log # tests/Fixtures/data/Test_GetQuery.log # tests/Fixtures/data/Test_MultipleWorkflowsInSingleWorker.log # tests/Fixtures/data/Test_PromiseChaining.log # tests/Fixtures/data/Test_RuntimeSignal.log # tests/Fixtures/data/Test_SendSignalBeforeCompletingWorkflow.log # tests/Fixtures/data/Test_SideEffect.log # tests/Fixtures/data/Test_SignalChildViaStubWorkflow.log # tests/Fixtures/data/Test_SignalSteps.log # tests/Fixtures/data/Test_Timer.log # tests/Functional/WorkflowTestCase.php # tests/Unit/Router/StartWorkflowTestCase.php
# Conflicts: # composer.json # src/Internal/Client/WorkflowStarter.php # src/Internal/Transport/Router/InvokeQuery.php # src/Internal/Transport/Router/StartWorkflow.php # src/Internal/Workflow/Process/Process.php # src/Internal/Workflow/Process/Scope.php # src/Internal/Workflow/WorkflowContext.php # src/Worker/Transport/Codec/JsonCodec/Decoder.php # src/Worker/Transport/Codec/ProtoCodec/Decoder.php # src/Worker/Transport/Command/Response.php # src/Worker/Transport/Command/ServerRequest.php # src/Worker/Transport/RoadRunner.php # src/Worker/Transport/RoadRunnerVersionChecker.php # src/Workflow/WorkflowContextInterface.php # src/Workflow/WorkflowInfo.php # tests/Functional/HistoryLengthWorkflowTestCase.php # tests/Unit/Framework/Server/ServerMock.php
…hods Header::setDataConverter() and Header::toHeader() internal
…boundCallsInterceptor interface
It is required to resolve promises in the right context.
…add activity method reflection when possible
Update Interceptors: polishing and improvements
roxblnfk
commented
Oct 23, 2023
Comment on lines
+1042
to
+1053
|
|
||
| // todo Remove from autogenerated file | ||
| public function getServerCapabilities(): ?ServerCapabilities | ||
| { | ||
| return $this->capabilities; | ||
| } | ||
|
|
||
| // todo Remove from autogenerated file | ||
| public function setServerCapabilities(ServerCapabilities $capabilities): void | ||
| { | ||
| $this->capabilities = $capabilities; | ||
| } |
There was a problem hiding this comment.
Should be resolved in a separated PR
wolfy-j
approved these changes
Oct 23, 2023
Sushisource
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
The main feature is interceptors. There are all the changes from #225.
Why?
It's time to move interceptors feature into the master branch and start beta testing.
Checklist
Related links:
temporal/open-telemetry-interceptorsOTEL interceptors repository