Set Nexus operation ID on callback headers #1710
Conversation
There was a problem hiding this comment.
LGTM.
Another non-blocking request is to always have the server generate the links (SDK can generate as a fallback when used with an old server).
That way operation ID is always coming from the SDK and the link from the server.
We should also document the implications of changing the operation ID returned from WorkflowRunOperation.Start. Let's tell them to never do that because the ID is used for cancelation and is reporting completion from the server.
| @@ -324,12 +325,21 @@ func ExecuteUntypedWorkflow[R any]( | |||
| if startWorkflowOptions.TaskQueue == "" { | |||
| startWorkflowOptions.TaskQueue = nctx.TaskQueue | |||
| } | |||
| if startWorkflowOptions.ID == "" { | |||
There was a problem hiding this comment.
I'm wondering if we want to require setting workflow ID for Nexus operations. We require it in all Core based SDKs, maybe we can at least protect Nexus users. Not blocking this PR though. @cretz, @Quinn-With-Two-Ns to weigh in on this.
There was a problem hiding this comment.
I thought the Go SDK did require setting a workflow ID for Nexus operations? I think it makes sense to require it or at least default it to something deterministic so starting a workflow is idempotent
What was changed
Setting
Nexus-Operation-Idheader on callback headers.Depends on nexus-rpc/sdk-go#26
Why?
This information is necessary for fabricating a NexusOperationStarted event if the completion is received before the response to a StartOperation request. This ID is set to the workflow ID unless the user provides a value for this header; user-provided values for this header are not overwritten.
Checklist
Closes
How was this tested:
Existing tests