Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Sticky Activities sample #75

Merged
merged 4 commits into from
Nov 12, 2023
Merged

Rename Sticky Activities sample #75

merged 4 commits into from
Nov 12, 2023

Conversation

lorensr
Copy link
Contributor

@lorensr lorensr commented Jun 29, 2023

@CLAassistant
Copy link

CLAassistant commented Jun 29, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor actionable comment, up to you if you want to fix now or not

worker_specific_task_queues/README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@cretz
Copy link
Member

cretz commented Jul 6, 2023

LGTM. You may also want to do this to https://github.com/temporalio/samples-dotnet/tree/main/src/ActivityStickyQueues and https://github.com/temporalio/samples-go/tree/main/activities-sticky-queues or at least open the issues.

You can feel free to merge this or I can.

@cretz
Copy link
Member

cretz commented Jul 24, 2023

@lorensr - Just merged #78 which conflicts here. Feel free to fix and merge.

@lorensr lorensr merged commit ba5a87f into main Nov 12, 2023
8 checks passed
@cretz cretz deleted the unstickify branch November 13, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants