Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed encrypted bytes to put tag last which matches the Java Sample #87

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

rross
Copy link
Contributor

@rross rross commented Oct 7, 2024

What was changed

Changed the arrangement of segments in the encrypted bytes to match how Java does it. (Nonce, Encrypted Data, Tag)

Why?

To provide encryption compatibility with our Java Encryption Sample,

  1. Closes

Not applicable

  1. How was this tested:

Tested in a different project to validate encryption is cross SDK compatible. Ran dotnet tests

  1. Any docs updates needed?
    No

@cretz
Copy link
Member

cretz commented Oct 7, 2024

Can you confirm what the behavior regarding tag placement is with https://github.com/temporalio/samples-typescript/tree/main/encryption, https://github.com/temporalio/samples-python/tree/main/encryption, and https://github.com/temporalio/samples-go/tree/main/encryption? At quick glance there is no tag on the latter two? Is it possible to confirm compatibility with this implementation and those 3 (ignoring Java for now)? I just want to confirm that .NET is the outlier and not Java.

Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this PR makes this sample work with multiple other-language samples repos. Marking approved. Merge at will.

@rross rross merged commit 5e0bbe7 into main Oct 7, 2024
6 checks passed
@rross rross deleted the MatchEncryptionToJava branch October 7, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants