Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SDK and fix flaky test #85

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Update SDK and fix flaky test #85

merged 1 commit into from
Aug 30, 2024

Conversation

cretz
Copy link
Member

@cretz cretz commented Aug 29, 2024

What was changed

  • Update SDK to 1.3.0
  • Fix flaky test by lowering the amount of events until continue as new to ensure it happens so assertion works

Checklist

  1. Closes [Bug] SafeMessageHandlers/ClusterManagerWorkflowTests - periodically failing last assertion #81

@cretz cretz requested a review from a team August 29, 2024 14:21
@cretz cretz merged commit 6e75911 into temporalio:main Aug 30, 2024
6 checks passed
@cretz cretz deleted the fix-flaky-cluster-manager-test branch August 30, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Quinn-With-Two-Ns Quinn-With-Two-Ns Quinn-With-Two-Ns approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] SafeMessageHandlers/ClusterManagerWorkflowTests - periodically failing last assertion
2 participants
@cretz @Quinn-With-Two-Ns