Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SignalsQueries sample #58

Merged
merged 9 commits into from
May 30, 2024
Merged

Add SignalsQueries sample #58

merged 9 commits into from
May 30, 2024

Conversation

lorensr
Copy link
Contributor

@lorensr lorensr commented Mar 28, 2024

Couple TODOs left, one with question

cretz
cretz reviewed Mar 28, 2024
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, welcome to .NET 😁

src/SignalsQueries/LoyaltyProgram.workflow.cs Outdated Show resolved Hide resolved
src/SignalsQueries/LoyaltyProgram.workflow.cs Outdated Show resolved Hide resolved
src/SignalsQueries/Program.cs Outdated Show resolved Hide resolved
src/SignalsQueries/Program.cs Outdated Show resolved Hide resolved
cretz
cretz approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would usually want tests for this, but this is good even without them (we don't have a strong precedent on requiring tests for samples). Still, may want a test to confirm behavior at some point.

@cretz cretz merged commit aa7fc9f into main May 30, 2024
6 checks passed
@cretz cretz deleted the signals branch May 30, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lorensr @cretz