Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize dynamic config #543

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Centralize dynamic config #543

merged 3 commits into from
Oct 10, 2024

Conversation

Sushisource
Copy link
Member

What was changed

Read dynamic config from a central location

Why?

Makes it easier for users of the repo in full-on environments like k8s have a file they can just grab and use for server dynamic config.

Checklist

  1. Closes Centralize dynamic config #529

  2. How was this tested:
    Existing features work that need these features enabled

  3. Any docs updates needed?

Copy link
Member

@cretz cretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, one of the reasons we called it --dynamic-config-value on the CLI was with the expectation there may be a --dynamic-config-file in the future. Would support adding that now if anyone has the time/desire.

@Sushisource
Copy link
Member Author

Note, one of the reasons we called it --dynamic-config-value on the CLI was with the expectation there may be a --dynamic-config-file in the future. Would support adding that now if anyone has the time/desire.

It requires changes to the server library itself to support stuff properly. Namely, merging of file-based and explicitly passed properties.

@Sushisource Sushisource merged commit a7698ed into main Oct 10, 2024
18 checks passed
@Sushisource Sushisource deleted the centralize-dynamic-config branch October 10, 2024 16:47
@roxblnfk roxblnfk mentioned this pull request Oct 23, 2024
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Centralize dynamic config
2 participants