Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: urlbuilder api ergonomics #5

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

garrettladley
Copy link
Contributor

addresses #4

  • changed signature of urlbuilder.New from New(scheme string, host string) *URLBuilder -> New(s) *URLBuilder`
  • helpers that return builders
    • urlbuilder.Scheme
    • urlbuilder.Host
    • urlbuilder.Path
  • additional tests for parity with templ.URL and the associated tests in templ
  • create .gitignore

TODO once merged, update docs in templ

Copy link

@aaronkim218 aaronkim218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants