Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add role argument spec and action to auto-update readme #233

Merged
merged 9 commits into from
Dec 6, 2023

Conversation

rndmh3ro
Copy link
Collaborator

@rndmh3ro rndmh3ro commented Dec 4, 2023

This adds a role argument spec to the role so it can be checked at runtime if all required parameters are set.
This helps us prevent issues like #34

@rndmh3ro rndmh3ro added enhancement New feature or request breaking labels Dec 4, 2023
@rndmh3ro rndmh3ro requested a review from a team as a code owner December 4, 2023 14:27
@rndmh3ro rndmh3ro force-pushed the role_arg_spec branch 2 times, most recently from 3cda189 to 7794450 Compare December 4, 2023 14:54
changelogs/changelog.yaml Outdated Show resolved Hide resolved
roles/ansible_icinga/tasks/icinga_host_template.yml Outdated Show resolved Hide resolved
.aar_doc.yml Show resolved Hide resolved
roles/ansible_icinga/tasks/icinga_command.yml Outdated Show resolved Hide resolved
@rndmh3ro rndmh3ro force-pushed the role_arg_spec branch 2 times, most recently from d8f1a3c to 8da7674 Compare December 6, 2023 11:00
@rndmh3ro rndmh3ro changed the title simplify role variables by removing one layer Add role argument spec and action to auto-update readme Dec 6, 2023
@rndmh3ro rndmh3ro removed the breaking label Dec 6, 2023
roles/ansible_icinga/meta/argument_specs.yml Outdated Show resolved Hide resolved
roles/ansible_icinga/meta/argument_specs.yml Outdated Show resolved Hide resolved
@rndmh3ro rndmh3ro merged commit f62560f into main Dec 6, 2023
34 checks passed
@rndmh3ro rndmh3ro deleted the role_arg_spec branch December 6, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants