-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add role argument spec and action to auto-update readme #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rndmh3ro
force-pushed
the
role_arg_spec
branch
2 times, most recently
from
December 4, 2023 14:54
3cda189
to
7794450
Compare
schurzi
reviewed
Dec 4, 2023
rndmh3ro
force-pushed
the
role_arg_spec
branch
2 times, most recently
from
December 6, 2023 11:00
d8f1a3c
to
8da7674
Compare
rndmh3ro
force-pushed
the
role_arg_spec
branch
from
December 6, 2023 11:10
8da7674
to
0f3df4e
Compare
This reverts commit 64b65ad.
rndmh3ro
changed the title
simplify role variables by removing one layer
Add role argument spec and action to auto-update readme
Dec 6, 2023
rndmh3ro
force-pushed
the
role_arg_spec
branch
from
December 6, 2023 11:56
a2d1a53
to
f24c539
Compare
schurzi
approved these changes
Dec 6, 2023
Co-authored-by: schurzi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a role argument spec to the role so it can be checked at runtime if all required parameters are set.
This helps us prevent issues like #34