Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 6 #24

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

reidmorrison
Copy link
Contributor

Description of changes

Support Rails 6

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@goodgravy
Copy link
Contributor

@reidmorrison this is awesome. Could you rebase so that I can better understand the diff after merging your other PR to bring us to version 3?

@v-kolesnikov
Copy link

@reidmorrison Hi! Any plans for merging this PR?

@reidmorrison
Copy link
Contributor Author

Yes, that would be great, we have been running my fork for several months in production now. We first started on Rails 6.0 and are now running Rails 6.1.
The changes above started with running RuboCop to fix syntax and include a major refactor to support Rails 6.x.

@sasharevzin
Copy link

The changes above started with running RuboCop to fix syntax and include a major refactor to support Rails 6.x.

would you also include .rubocop.yml file with? I’m wondering what are cops were used.

@reidmorrison
Copy link
Contributor Author

Lol, good point, I have a .rubocop.yml file in the root path for all my open source projects. I need to add it to not only to this PR but all my own open source projects. 👍

@reidmorrison
Copy link
Contributor Author

reidmorrison commented Dec 31, 2021

@goodgravy I see you gave me merge privileges to this repo, do you want me to do a squash merge of the above commits?

This gem can be significantly simplified if we create a new major version that only supports Rails 6 and above, since it can use the Rails built-in multi-database support. I can work on that approach if there is interest?
It will also make supporting multiple replicas fairly straight forward to meet @mainameiz's requirements.

@sasharevzin
Copy link

@reidmorrison I would love to use it with multiple replicas 😀

@Bukvar1337
Copy link

@reidmorrison, have you updated to rails 7? If so, are you still using this gem?

@kopylovvlad
Copy link

Hello, guys. My team is migrating from Rails 6 to Rails 7 and we are interesting in any solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants