Drop unique app name index

It is possible two apps share the same name, however the package is the
only thing that will stay unique. So we can safely drop the unique name
db constraint, and let apps get added that are the same name. They will
look different in most cases due to image/package.

This resolves: techlore/Plexus-app#33

lib/plexus/schemas/app.ex

@@ -22,7 +22,6 @@ defmodule Plexus.Schemas.App do
     app
     |> cast(params, [:package, :name, :icon_url])
     |> validate_required([:package, :name])
-    |> unique_constraint(:name)
     |> unique_constraint(:package, name: :apps_pkey)
   end
 end

priv/repo/migrations/20240715234120_remove_apps_name_unique_index.exs

@@ -0,0 +1,7 @@
+defmodule Plexus.Repo.Migrations.RemoveAppsNameUniqueIndex do
+  use Ecto.Migration
+
+  def change do
+    drop_if_exists index(:apps, [:name])
+  end
+end

test/plexus/apps_test.exs

@@ -83,12 +83,5 @@ defmodule Plexus.AppsTest do
       attrs = %{package: app.package, name: unique_app_name()}
       assert {:error, %Ecto.Changeset{}} = Apps.create_app(attrs)
     end
-
-    test "with duplicate name returns error changeset" do
-      app = app_fixture()
-
-      attrs = %{package: unique_app_package(), name: app.name}
-      assert {:error, %Ecto.Changeset{}} = Apps.create_app(attrs)
-    end
   end
 end

test/plexus_web/controllers/api/v1/app_controller_test.exs

@@ -70,14 +70,6 @@ defmodule PlexusWeb.API.V1.AppControllerTest do
              } = json_response(conn, 422)
     end
 
-    test "renders error when name is already taken", %{conn: conn} do
-      app = app_fixture()
-      attrs = %{@create_attrs | name: app.name}
-
-      conn = post(conn, ~p"/api/v1/apps", app: attrs)
-      assert %{"errors" => %{"name" => ["has already been taken"]}} = json_response(conn, 422)
-    end
-
     test "renders error when package is already taken", %{conn: conn} do
       app = app_fixture()
       attrs = %{@create_attrs | package: app.package}