Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drive with joysticks fix #36

Merged
merged 3 commits into from
Dec 14, 2023
Merged

Drive with joysticks fix #36

merged 3 commits into from
Dec 14, 2023

Conversation

honzikschenk
Copy link
Contributor

@honzikschenk honzikschenk commented Dec 14, 2023 •
edited by linglejack06
Loading

Summary
Creates a DriveWithJoysticks command to alleviate spaghetti in RobotContainer.

Work Scope

  • Create DriveWithJoysticks command
  • Implement babyMode and field relative
  • Factor in new deadband util

@honzikschenk honzikschenk added the enhancement New feature or request label Dec 14, 2023
@honzikschenk honzikschenk self-assigned this Dec 14, 2023
charlesmackenzie
charlesmackenzie suggested changes Dec 14, 2023
View reviewed changes
Copy link

@charlesmackenzie charlesmackenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I commented on a variable name, but that should be it.

src/main/java/frc/robot/RobotContainer.java Outdated Show resolved Hide resolved
charlesmackenzie
charlesmackenzie approved these changes Dec 14, 2023
View reviewed changes
Copy link

@charlesmackenzie charlesmackenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool

@honzikschenk honzikschenk merged commit 482a0bc into main Dec 14, 2023
2 checks passed
@honzikschenk honzikschenk deleted the DriveWithJoysticks-Fix branch December 14, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesmackenzie charlesmackenzie charlesmackenzie approved these changes

Assignees

@honzikschenk honzikschenk

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@honzikschenk @charlesmackenzie